Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalDAV OPTIONS: do not announce calendar-auto-schedule when CY:scheduling-enabled is F #5081

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

dilyanpalauzov
Copy link
Contributor

This way client software can show to the user when server-side scheduling is disabled. The client software can then offer to send iMIP messages.

While _scheduling_enabled() calls

annotatemore_lookupmask_mbox(mailbox, DAV_ANNOT_NS "<" XML_NS_CYRUS ">scheduling-enabled", "", &buf);`

this function executes

annotatemore_lookup_mbe(mbentry, DAV_ANNOT_NS "<" XML_NS_CYRUS ">scheduling-enabled", "", &buf);`

The difference is, that the former also invokes

/* and because of Bron's use of NULL rather than "" at FastMail... */
if (value->len == 0)
    r = _annotate_lookup(mboxname, mboxid, uid, entry, NULL, value);

I do not understand how this NULL is supposed to work at FastMail.

@ksmurchison ksmurchison merged commit db4250e into cyrusimap:master Oct 11, 2024
1 check passed
@dilyanpalauzov dilyanpalauzov deleted the caldav_options branch October 11, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants