http_caldav.c: do not require tzdist module for calendar-timezone-id #5065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksmurchison
reviewed
Oct 3, 2024
|
I thought that, too. We could but it would enable a couple of other features, too. |
ksmurchison
reviewed
Oct 3, 2024
rsto
force-pushed
the
http_caldav_proppatch_timezone_id
branch
from
1ff33b7
to
4dbcf4f
Compare
|
Agreed. Applied change and restarted CI. |
ksmurchison
approved these changes
Oct 3, 2024
rsto
force-pushed
the
http_caldav_proppatch_timezone_id
branch
from
4dbcf4f
to
30dbd79
Compare
|
Could not reproduce CI failures on local build. Most likely a VM glitch. Rerunning CI. |
rsto
force-pushed
the
http_caldav_proppatch_timezone_id
branch
from
30dbd79
to
ffe619a
Compare
|
proppatch_tzid() could reject acting on Scheduling Outbox and Attachments. caldav_get_calendar_tz() looks for the timezone in the collection and in the calendar-homeset. It is reasonable to allow proppatch_tzid() and proppatch_timezone() when req_tgt.userid is set, fctx->req_tgt->resource is not set, and irrespective of whether fctx->req_tgt->collection is NULL. |
rsto
force-pushed
the
http_caldav_proppatch_timezone_id
branch
from
ffe619a
to
0612d1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.