jmap_contact_from_vcard() tautology with strarray_safenth() #4576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strarray_safenth() cannot return NULL. The change here presents the intended logic.
elliefm
approved these changes
Aug 20, 2023
|
@ksmurchison: This looks good and I've approved it, but I have a feeling it might conflict with your contacts refactoring in #4479, so I'll leave it for you to decide whether to actually merge it or not. |
|
Superseded by #4788 |
dilyanpalauzov
added a commit
to dilyanpalauzov/cyrus-imapd
that referenced
this pull request
Sep 24, 2024
strarray_safenth() cannot return NULL. The change here presents the intended logic. Affected are 3.8, 3.6, 3.4 and 3.2 branches. cyrusimap#4576 APPLICABLE TO 3.10 UPSTREAM MIGHT USE cyrusimap#4788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strarray_safenth() cannot return NULL.
The change here presents the intended logic.
Affected are 3.8, 3.6, 3.4 and 3.2 branches.