Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jmap_calendar: support FilterOperator in dav.db queries #4524

Merged
merged 6 commits into from
Jul 26, 2023

Conversation

rsto
Copy link
Member

@rsto rsto commented Jun 6, 2023

CalendarEvent/query filters using any of the AND/OR/NOT operators were not supported using dav.db. This now supports such queries, allowing both for faster lookup and for previously unsupported queries such as OR(uid1,uid2,uid2).

@rsto rsto requested a review from ksmurchison June 6, 2023 11:32
@rsto rsto force-pushed the jmap_calendars_query_davdb branch from a031dd1 to 9d84cdf Compare June 6, 2023 11:35
Copy link
Contributor

@ksmurchison ksmurchison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsto rsto force-pushed the jmap_calendars_query_davdb branch from 9ac1db8 to 5825a74 Compare June 27, 2023 12:44
@rsto
Copy link
Member Author

rsto commented Jun 27, 2023

Now updated with support to

  • optimize for OR(uid, uid, ..) queries
  • return a distinct sqldb error if SQL errors are too large
  • return unsupportedFilter for too large queries

@ksmurchison could you please review the latest three commits, especially the sqldb changes?

@rsto rsto force-pushed the jmap_calendars_query_davdb branch 2 times, most recently from 0562aba to ee273ae Compare June 27, 2023 12:52
Copy link
Contributor

@ksmurchison ksmurchison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsto rsto force-pushed the jmap_calendars_query_davdb branch from ee273ae to bb035aa Compare June 28, 2023 14:03
@rsto rsto merged commit 9541400 into master Jul 26, 2023
@rsto rsto deleted the jmap_calendars_query_davdb branch July 26, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants