-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jmap_calendar: support FilterOperator in dav.db queries #4524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsto
force-pushed
the
jmap_calendars_query_davdb
branch
from
June 6, 2023 11:35
a031dd1
to
9d84cdf
Compare
ksmurchison
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rsto
force-pushed
the
jmap_calendars_query_davdb
branch
from
June 7, 2023 08:52
9d84cdf
to
9ac1db8
Compare
Signed-off-by: Robert Stepanek <[email protected]>
Signed-off-by: Robert Stepanek <[email protected]>
Signed-off-by: Robert Stepanek <[email protected]>
rsto
force-pushed
the
jmap_calendars_query_davdb
branch
from
June 27, 2023 12:44
9ac1db8
to
5825a74
Compare
Now updated with support to
@ksmurchison could you please review the latest three commits, especially the sqldb changes? |
Signed-off-by: Robert Stepanek <[email protected]>
Signed-off-by: Robert Stepanek <[email protected]>
rsto
force-pushed
the
jmap_calendars_query_davdb
branch
2 times, most recently
from
June 27, 2023 12:52
0562aba
to
ee273ae
Compare
ksmurchison
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Robert Stepanek <[email protected]>
rsto
force-pushed
the
jmap_calendars_query_davdb
branch
from
June 28, 2023 14:03
ee273ae
to
bb035aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CalendarEvent/query filters using any of the AND/OR/NOT operators were not supported using dav.db. This now supports such queries, allowing both for faster lookup and for previously unsupported queries such as OR(uid1,uid2,uid2).