register DAEMON and EVENTS processes so cyr_info proc can list them #4522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliefm
force-pushed
the
v39/proc-info-for-daemons
branch
5 times, most recently
from
0c77f97
to
979f751
Compare
elliefm
force-pushed
the
v39/proc-info-for-daemons
branch
2 times, most recently
from
5dbe167
to
bb04488
Compare
will be needed for master to use its functions
(this just makes the next commit easier to read)
elliefm
force-pushed
the
v39/proc-info-for-daemons
branch
5 times, most recently
from
9f99dfd
to
9ccabd2
Compare
and existing callers now check the return value and fatal themselves
The defining property of these objects is that they are listening on a port, which conflicts with Cyrus's use of DAEMON for things that are not listening on a port.
not strictly related to this PR, but I've been wanting to do this for ages, and now I can, and it shows that the previous commit works
elliefm
force-pushed
the
v39/proc-info-for-daemons
branch
from
9ccabd2
to
6ba241f
Compare
elliefm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reviewers: This will be easiest to review commit-by-commit.
cyr_info proclists all the running processes for cyrus.conf SERVICES entries. This PR extends this to also include processes for EVENTS and DAEMON entries. With this change,cyr_info proclists all* running processes managed bymaster.The existing SERVICES processes register themselves using the API functions provided by imap/proc.c. EVENT and DAEMON processes are expected to often be external scripts, so their registration is taken care of directly by master. This required relocating the proc.c API functions from libcyrus_imap to libcyrus_min (so that master can call them), and refactoring to make them re-entrant (because master needs to register its many children, not itself).
Some Cassandane internals needed a small refactor to make this testable, and I found and fixed a bug in our cunit test logging too.
Processes from the START section are not registered, and thus not listed by
cyr_info proc. Since these are by definition short-lived processes that only run once during startup -- and if they fail, startup fails -- it didn't seem worth it. I could be persuaded otherwise.