jmap_contact.c: don't add kind:title, since its the default

cyrusimap · Jun 19, 2023 · ba6307a · ba6307a
1 parent dc6e8e3
commit ba6307a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/cassandane/tiny-tests/JMAPContacts/card-get-v3 b/cassandane/tiny-tests/JMAPContacts/card-get-v3
@@ -74,7 +74,6 @@ EOF
         'name' => 'Bubba Gump Shrimp Co.'
     }, $res->[0][1]{list}[0]{organizations}{O1});
     $self->assert_deep_equals({
-        'kind' => 'title',
         'name' => 'Shrimp Man'
     }, $res->[0][1]{list}[0]{titles}{T1});
     $self->assert_deep_equals({

diff --git a/imap/jmap_contact.c b/imap/jmap_contact.c
@@ -7016,11 +7016,9 @@ static json_t *jmap_card_from_vcard(const char *userid,
         case VCARD_TITLE_PROPERTY: {
             json_t *titles = json_object_get_vanew(obj, "titles", "{}");
 
-            if (!kind) kind = "title";
-
             prop_value = vcardproperty_get_title(prop);
             json_object_set_new(titles, _prop_id(prop),
-                                json_pack("{s:s s:o}",
+                                json_pack("{s:s* s:o}",
                                           "kind", kind,
                                           "name",
                                           jmap_utf8string(prop_value)));