Skip to content

Commit

Permalink
WIP still broken...
Browse files Browse the repository at this point in the history
one problem is that the missing features test happens very early!
if we get wants from :want_foo then those have already been processed

but if we get wants from ordinary magic (e.g. :Replication), that
magic doesn't get invoked until _create_instances() is run, and at
that point it's too late to start adding stuff to the needs hash,
the skip_missing_features filter has already run!

can we _run_magic() earlier, perhaps?

the alternative is needing to add a bunch of :want_replica and such
to tests that previously implicitly got that by having "replication"
in their name or ":Replication" in their attributes.
  • Loading branch information
elliefm committed Sep 16, 2024
1 parent 6114bc0 commit a5c8424
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions cassandane/Cassandane/Cyrus/TestCase.pm
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,7 @@ sub want

if ($want_needs->{$name}) {
foreach my $need (@{$want_needs->{$name}}) {
xlog "XXX want '$name' implies need @{$need}";
$self->needs(@{$need});
}
}
Expand Down
2 changes: 1 addition & 1 deletion cassandane/tiny-tests/Caldav/replication_delete
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
use Cassandane::Tiny;

sub test_replication_delete
:needs_component_replication
:want_replica
{
my ($self) = @_;

Expand Down

0 comments on commit a5c8424

Please sign in to comment.