Merge pull request #5073 from elliefm/v311/3826-error-message-0-fix

lmtpengine: don't rely on error_message(0) for success string
cyrusimap · Oct 10, 2024 · 81e8708 · 81e8708
2 parents c0ebb2a + 081e815
commit 81e8708
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/imap/lmtpengine.c b/imap/lmtpengine.c
@@ -133,6 +133,7 @@ static struct saslprops_t saslprops = SASLPROPS_INITIALIZER;
 
 static void send_lmtp_error(struct protstream *pout, int r, strarray_t *resp)
 {
+    const char *text = error_message(r);
     int code;
 
     if (resp) {
@@ -146,6 +147,8 @@ static void send_lmtp_error(struct protstream *pout, int r, strarray_t *resp)
 
     switch (r) {
     case 0:
+        /* n.b. can't rely on error_message(0) to produce a success string */
+        text = "Success";
         code = LMTP_OK;
         break;
 
@@ -224,7 +227,7 @@ static void send_lmtp_error(struct protstream *pout, int r, strarray_t *resp)
         break;
     }
 
-    prot_printf(pout, error_message(code), error_message(r), session_id());
+    prot_printf(pout, error_message(code), text, session_id());
     prot_puts(pout, "\r\n");
 }