feat: add burn-in to test execution logic #27965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MuazOthman
changed the title
19 failed tests on run #51421 ↗︎
Details:
|
||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
The first 5 failed specs are shown, see all 987 specs in Cypress Cloud.
Review all test suite changes for PR #27965 ↗︎
cacieprins
reviewed
Oct 19, 2023
cacieprins
reviewed
Oct 19, 2023
| // If there is AT LEAST one failed test attempt, we know we need to apply retry logic. | ||
| // Otherwise, the test might be burning in (not implemented yet) OR the test passed on the first attempt, | ||
| // meaning retry logic does NOT need to be applied. | ||
| if (failedTests.length > 0) { | ||
| test.nextAttemptStrategy = 'RETRY' |
There was a problem hiding this comment.
nextAttemptStrategy is only referenced to set thisAttemptStrategy; is this logic necessary?
There was a problem hiding this comment.
This is so we can indicate if the next attempt is to be made as part of a retry. I'm not sure if there's another way to do it.
cacieprins
reviewed
Oct 19, 2023
| outerTestStatus = 'passed' | ||
| test.final = true | ||
| shouldAttemptsContinue = false | ||
| test.reasonToStop = 'PASSED_MET_THRESHOLD' |
There was a problem hiding this comment.
reasonToStop is only set, and never referenced - is this a field we'll be sending to the cloud?
There was a problem hiding this comment.
Yes, see the description here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?