Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shutdown: terminate subprocesses #636

Merged

Conversation

oliver-sanders
Copy link
Member

Backport of #619

Not sure why I put the original fix on master. It might have been because I was anticipating bumping the jupyterhub min requirement to pick up the bugfix, it might just have been an accident.

We could do with this sooner rather than later now we've got a larger deployment in the wild.


  • We use a subprocess pool for running backgorund commands (e.g. cylc clean).
  • This creates subprocesses to run our commands in, however, it does not kill the subprocess once the command has completed, it keeps the subprocess open for future reuse (more efficient than creating and destroying them every time).
  • On shutdown we need to close the pool to mop up these subprocesses (this doesn't happen automatically).

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

* We use a subprocess pool for running backgorund commands
  (e.g. `cylc clean`).
* This creates subprocesses to run our commands in, however, it does
  not kill the subprocess once the command has completed, it keeps
  the subprocess open for future reuse (more efficient than creating
  and destroying them every time).
* On shutdown we need to close the pool to mop up these subprocesses
  (this doesn't happen automatically).
@oliver-sanders oliver-sanders added this to the 1.5.1 milestone Oct 15, 2024
@oliver-sanders oliver-sanders self-assigned this Oct 15, 2024
@oliver-sanders oliver-sanders merged commit 4c3de86 into cylc:1.5.x Oct 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants