More gracefully override JPS ExtensionApp.config_file_paths
#612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
changed the title
ExtensionApp.config_file_paths
MetRonnie
changed the title
ExtensionApp.config_file_pathsExtensionApp.config_file_paths
Comment on lines
+416
to
+429
| @property | ||
| def config_file_paths(self) -> List[str]: | ||
| if self._config_file_paths is None: | ||
| ret = get_conf_dir_hierarchy( | ||
| [ | ||
| SITE_CONF_ROOT, # site configuration | ||
| USER_CONF_ROOT, # user configuration | ||
| ], filename=False | ||
| ) | ||
| # Next include currently needed for directory making | ||
| ret.insert(0, str(Path(uis_pkg).parent)) # packaged config | ||
| ret.reverse() | ||
| self._config_file_paths = ret | ||
| return self._config_file_paths |
There was a problem hiding this comment.
This change does not appear to be necessary, the only bit that's needed is the autouse?
There was a problem hiding this comment.
Couldn't get the monkeypatching to work without this change. Not sure why, but pyright is not happy with overriding a property with a class attribute anyway (see microsoft/pyright#3646 (comment))
There was a problem hiding this comment.
Monkeypatching seems to work fine for me (with your config)?
I found the config_file_paths definition in Jupyter_Core and it is indeed a property so this makes sense 👍.
oliver-sanders
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows patching in the tests so the tests don't pick up our user/site configs. Currently the tests fail locally for me because they pick up my config.