Avoid requiring jupyter_config.py in to be in uiserver subdirectory
#594
+65
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erver Remove the need for the uiserver subdirectory. Ensure that user is warned if file at CYLC_SITE_CONF_PATH is * Unreadable * Non-existent
wxtim
force-pushed
the
fix.respect_CYLC_SITE_CONF_PATH
branch
from
ac02b14
to
00708ae
Compare
oliver-sanders
requested changes
Oct 15, 2024
There was a problem hiding this comment.
Previously it was assumed to be in CYLC_SITE_CONF_PATH/uiserver.
This was correct and consistent with cylc-flow which looks in $CYLC_SITE_CONF_PATH/flow.
The CYLC_SITE_CONF_PATH directory is supposed to look like this:
.
|-- flow
| `-- global.cylc
`-- uiserver
`-- jupyter_config.py
The intention is that it can be used to configure all of the Cylc components.
As of the current versions setting CYLC_SITE_CONF_PATH to the root of the above structure works fine for me.
So this can be closed? |
|
Check the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #565
Previously it was assumed to be in
CYLC_SITE_CONF_PATH/uiserver.Ensure that user is warned if file at
CYLC_SITE_CONF_PATHisCheck List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.