Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow local logs for cat-log #509

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ScottWales
Copy link

Add a configuration item c.CylcUIServer.force_remote_logs defaulting to True (matching existing behaviour)

When True, cat-log will use the --force-remote option to always fetch from the remote Cylc server

When False logs will only be fetched if they are not present on the local server

Fixes #506

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders
Copy link
Member

As mentioned in #506 there shouldn't be a need to make this configurable, someone needs to go through the cat-log code and make any required adjudgements to ensure that the command uses the local files when available and file listings remain correct. This isn't something I've had the time to do so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuration to tell cat-log to fetch logs from (local) disk rather than remote host
2 participants