Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove variable-length lookbehinds #49

Merged
merged 2 commits into from
May 15, 2024
Merged

Remove variable-length lookbehinds #49

merged 2 commits into from
May 15, 2024

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented May 14, 2024

This is needed to allow the Textmate grammar to be added to GitHub Linguist. Currently:

Invalid regex in grammar: source.cylc (in Syntaxes/cylc.tmLanguage) contains a malformed regex (regex "(?<=(\b\w[\w\+\-@%]*|((:)([\w\-]...": lookbehind assertion is not fixed length (at offset 43))

https://github.com/oliver-sanders/linguist/actions/runs/8569942718/job/23486858235#step:4:78

This unfortunately makes the grammar slightly less able to handle Jinja2 cropping up anywhere, but worth the tradeoff

@MetRonnie MetRonnie self-assigned this May 14, 2024
@oliver-sanders
Copy link
Member

I've given in trying to get the linguist compiler to run for this repo in CI, let's try merging this and see what it spits out next time.

@oliver-sanders oliver-sanders merged commit 76359a6 into master May 15, 2024
1 check passed
@oliver-sanders oliver-sanders deleted the lookbehind branch May 15, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants