Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added flake8-type-checking #257

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

markgrahamdawson
Copy link
Contributor

@markgrahamdawson markgrahamdawson commented Oct 17, 2023

Closes cylc/cylc-admin#182

Added flake8-type-checking library to project

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@markgrahamdawson markgrahamdawson self-assigned this Oct 17, 2023
@MetRonnie MetRonnie added this to the 1.3.1 milestone Oct 17, 2023
@MetRonnie MetRonnie changed the base branch from master to 1.3.x October 17, 2023 15:17
@MetRonnie
Copy link
Member

Can you rebase onto 1.3.x please

@MetRonnie MetRonnie merged commit 8b5d7f2 into cylc:1.3.x Oct 18, 2023
6 checks passed
wxtim pushed a commit to wxtim/cylc-rose that referenced this pull request Oct 24, 2023
wxtim added a commit to wxtim/cylc-rose that referenced this pull request Oct 24, 2023
* upstream/1.3.x:
  Bump dev version
  Prepare release 1.3.1
  added flake8-type-checking (cylc#257)
  remove back compatibility check
  Raise error if = not in define
  Ensure that a `:suite.rc` is added to the template language when creating defines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake8-type-checking
2 participants