Suggested change to warning text re integers starting with a zero #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… found in the cylc workflow definition.
hjoliver
reviewed
Oct 5, 2023
| ' Rose will extend support until a future version.' | ||
| '\nPlease amend your Rose configuration files e.g:' | ||
| '\nPlease amend your Rose configuration files, | ||
| ' which currently contain:' |
oliver-sanders
approved these changes
Oct 5, 2023
wxtim
approved these changes
Oct 5, 2023
wxtim
reviewed
Oct 5, 2023
wxtim
reviewed
Oct 5, 2023
wxtim
requested changes
Oct 5, 2023
There was a problem hiding this comment.
You need to terminate your strings - I've given you some suggestions - this is my only objection, if the tests build I'm happy for @MetRonnie to whack merge without further review from me.
Co-authored-by: Tim Pillinger <[email protected]>
|
MetRonnie or MetOllie? |
Either will Do |
wxtim
approved these changes
Oct 5, 2023
wxtim
added a commit
to wxtim/cylc-rose
that referenced
this pull request
Oct 24, 2023
…lc#255) * Suggested change to warning text when integers with leading zeros are found in the cylc workflow definition. * Apply suggestions from code review Co-authored-by: Tim Pillinger <[email protected]> --------- Co-authored-by: Oliver Sanders <[email protected]> Co-authored-by: Tim Pillinger <[email protected]>
wxtim
added a commit
to wxtim/cylc-rose
that referenced
this pull request
Oct 24, 2023
…lc#255) * Suggested change to warning text when integers with leading zeros are found in the cylc workflow definition. * Apply suggestions from code review Co-authored-by: Tim Pillinger <[email protected]> --------- Co-authored-by: Oliver Sanders <[email protected]> Co-authored-by: Tim Pillinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested change to warning text when integers with leading zeros are encountered.
This PR addresses issue #254
Tests not needed because only warning text is changed.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.