Get Cylc template variables from database for validation. #5189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
20221010T0945--HEAD--get_template_vars_from_running_wf
branch
from
08db7c2
to
a438418
Compare
wxtim
changed the title
wxtim
force-pushed
the
20221010T0945--HEAD--get_template_vars_from_running_wf
branch
3 times, most recently
from
77823b7
to
f7ba0b9
Compare
|
Now working :) |
wxtim
force-pushed
the
20221010T0945--HEAD--get_template_vars_from_running_wf
branch
2 times, most recently
from
290d794
to
5935610
Compare
… collected from database of already played workflows. - Added `--revaladidate` as an option to the following scripts (Made async to allow testing of changes): - cylc validate - cylc view - cylc graph - cylc config
wxtim
force-pushed
the
20221010T0945--HEAD--get_template_vars_from_running_wf
branch
from
5935610
to
b2e51e2
Compare
cylc/flow/option_parsers.py
Outdated
Comment on lines
448
to
453
| if self.revalidate: | ||
| self.add_std_option( | ||
| '--revalidate', | ||
| help="Get template variables from prevous workflow run.", | ||
| action='store_true', default=False | ||
| ) |
There was a problem hiding this comment.
Were we going to infer this option if the provided workflow is a run directory?
| @@ -251,7 +251,7 @@ def process_plugins(fpath, opts): | |||
| # If you want it to work on sourcedirs you need to get the options | |||
| # to here. | |||
| plugin_result = entry_point.resolve()( | |||
| srcdir=fpath, opts=opts | |||
| fpath, opts=opts | |||
There was a problem hiding this comment.
Note: Double check that cylc-rose is ok with this.
| """Extract key and value and run eval_var on them assigning | ||
| them to self.template_vars. | ||
| """ | ||
| self.template_vars[row[0]] = eval_var(row[1]) |
There was a problem hiding this comment.
Note: check that eval_var doesn't require fancy error catching for its other uses in the code.
There was a problem hiding this comment.
I'm not sure what you're asking me here.
|
This will want rebasing on Cylc VIP branch after merge. |
Co-authored-by: Hilary James Oliver <[email protected]>
… of github.com:wxtim/cylc into 20221010T0945--HEAD--get_template_vars_from_running_wf * '20221010T0945--HEAD--get_template_vars_from_running_wf' of github.com:wxtim/cylc: (51 commits) make revalidate automatic if workflow has changed at source play: --upgrade and --downgrade options Fix consolidation tutorial (cylc#5199) 8.0.x -> master (cylc#5206) GH Actions Codecov upload: try using token arg (cylc#5179) Update CHANGES.md [skip ci] Add type hints. Switch to better monkeypatching approach. [skip ci] Add explanatory comments. [skip ci] Update CHANGES.md [skip ci] play: check Cylc version on restart Use a context manager in new test. Update change log. Extend new test coverage. install: scan only target workflow Apply suggestions from code review Add integration test. Scan workflow name during install. fix an error handling bug in Cylc Scan update PR template (cylc#5202) ...
8 tasks
|
I'm leaving this in draft format - I prefer the approach I took in #5214 - and that will probably form the basis for the work on validation for reinstall. |
wxtim
deleted the
20221010T0945--HEAD--get_template_vars_from_running_wf
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowed "revalidation" of cylc workflows where template variables are collected from
Probably closes #4740
database of already played workflows.
--revaladidateas an option to the following scripts (Made async to allow testing of changes):Check List
CONTRIBUTING.mdand added my name as a Code Contributor.CHANGES.mdentry included if this is a change that can affect users