test: migrate envtests to komega #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces komega from controller-runtime envtest framework. IMO it makes the test more readable and test-code shorter. Also standardizing on the Ginkgo pattern to use
Expect(<func>).Should(Succeed())when the K8s client operation is supposed to success without error. It just makes things a bit more compact.I hope you like this, and that the PR is reviewable. It is a bit large in the number of changes, but I have attempted to change things in a way that doesn't clutter the diff.
This PR is mainly motivated by planned test improvements in #112.