chore(helm): allow CRDs to be templated with Helm #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgb
force-pushed
the
template-crds
branch
from
7a29f8e
to
b6764d0
Compare
erikgb
changed the title
erikgb
force-pushed
the
template-crds
branch
from
b6764d0
to
63d0ca8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is migrating away from the CRD "support" in Helm, making the CRDs regular Helm templates. This is a common workaround for the non-existing CRD support in Helm.
Unblocks #107.
I am proposing to make Helm management of CRDs the default, but cert-manager decided to make it an opt-in. Both approaches have their pros and cons. Let me know what you think!
We don't use Helm in our clusters, but instead use the Helm support in kustomize to template resources client-side. I am not sure how easy it would be to migrate to the new way of managing CRDs with Helm. Maybe you can help me test so we can add some docs?