Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

Fix another silently failing rgeo build issue #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

woahdae
Copy link
Contributor

@woahdae woahdae commented Jun 26, 2019

Previously, passing in --with-opt-dir and --with-geos-config worked
fine. After upgrading my app to Ruby 2.6 and latest bundler, options
passed in through bundler don't seem to make it down to the C extension.

It's worth noting also, a couple years ago, rgeo changed what the
options were called, which resulted in heroku-geo-buildpack silently
breaking (PR #34).

This change puts geos-config and the misc build dependencies in
$PATH and $CPATH/$LD_LIBRARY_PATH/$LIBRARY_PATH as appropriate, so we
never have to deal with issues around passing arguments to bundler
again. Additionally, if you start a heroku bash prompt, you can fuss
with geos and building rgeo without learning the build options, which is
nice.

Previously, passing in `--with-opt-dir` and `--with-geos-config` worked
fine. After upgrading my app to Ruby 2.6 and latest bundler, options
passed in through bundler don't seem to make it down to the C extension.

It's worth noting also, a couple years ago, rgeo changed what the
options were called, which resulted in heroku-geo-buildpack silently
breaking (PR cyberdelia#34).

This change puts `geos-config` and the misc build dependencies in
$PATH and $CPATH/$LD_LIBRARY_PATH/$LIBRARY_PATH as appropriate, so we
never have to deal with issues around passing arguments to bundler
again. Additionally, if you start a heroku bash prompt, you can fuss
with geos and building rgeo without learning the build options, which is
nice.
@woahdae
Copy link
Contributor Author

woahdae commented Jun 26, 2019

This also happens to fix #48

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant