Fix "creation of dynamic property" deprecation notices

with PHP 8.2
cweiske · Jul 17, 2024 · a59c579 · a59c579
1 parent 4f401ab
commit a59c579
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 2 deletions.
diff --git a/tests/OtherTest.php b/tests/OtherTest.php
@@ -187,12 +187,12 @@ public function testUndefinedPropertyHandler()
             new JsonMapperTest_Broken()
         );
 
-        $this->assertSame(123, $sn->ADDundefinedProperty);
+        $this->assertSame(123, $sn->store['undefinedProperty']);
     }
 
     public function setUnknownProperty($object, $propName, $jsonValue)
     {
-        $object->{'ADD' . $propName} = $jsonValue;
+        $object->store[$propName] = $jsonValue;
     }
 
     public function testPrivatePropertyWithPublicSetter()

diff --git a/tests/support/JsonMapperTest/Broken.php b/tests/support/JsonMapperTest/Broken.php
@@ -31,5 +31,7 @@ class JsonMapperTest_Broken
      * @required
      */
     public $pMissingData;
+
+    public $store;
 }
 ?>
diff --git a/tests/support/JsonMapperTest/Object.php b/tests/support/JsonMapperTest/Object.php
@@ -27,6 +27,10 @@ class JsonMapperTest_Object
      */
     public $pString;
 
+    public $nullableObject;
+
+    public $docblockNullableObject;
+
     public function setNullableObject(JsonMapperTest_PlainObject $obj = null)
     {
         $this->nullableObject = $obj;

diff --git a/tests/support/JsonMapperTest/PHP7Object.php b/tests/support/JsonMapperTest/PHP7Object.php
@@ -2,6 +2,10 @@
 
 class JsonMapperTest_PHP7Object
 {
+    public $nonNullableObject;
+
+    public $typeNullableObject;
+
     public function setTypeNullableObject(?JsonMapperTest_PlainObject $obj)
     {
         $this->typeNullableObject = $obj;

diff --git a/tests/support/JsonMapperTest/Simple.php b/tests/support/JsonMapperTest/Simple.php
@@ -20,6 +20,8 @@
  */
 class JsonMapperTest_Simple
 {
+    public $db;
+
     /**
      * @var bool
      */