-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made some refactoring, fixed some potential issues #8
base: master
Are you sure you want to change the base?
Conversation
…erit from but method signature at this point
…n passed in settings
The first 12 checkins had poor comments .. at that point I didn't intend for a merge up but just checking out the code. |
use stash to clean up the "in-between" comments. |
Looks good to me. Was that last comment for me to do or have you already done it? Thanks! |
No more changes. I should have given u a branch instead of the master .. and squash the extra comments. |
Hi,
Made some refactoring summary: