Update and reorganize dependencies #123
Conversation
|
Thank you very much for your contribution. It is very meaningful to not only congratulate for the app, but literally give something from yourself. |
|
Unfortunetely I see that checks fails and it is something with Gradle version and the |
Signed-off-by: Patryk Miś <[email protected]>
* Android Gradle Plugin to v8.2.0 * AndroidX * TensorFlow Lite * Fix `LintOptions` deprecation * Remove clean task: it is already provided by AGP and well-working * Remove Kapt and other plugins and dependencies that are not being used * other dependency reorganizations * remove license clause from build file as it becames highly-customized for this specific app Signed-off-by: Patryk Miś <[email protected]>
Signed-off-by: Patryk Miś <[email protected]>
PatrykMis
force-pushed
the
chore/dependency-updates
branch
from
fb132e5
to
87a6625
Compare
Signed-off-by: Patryk Miś <[email protected]>
Signed-off-by: Patryk Miś <[email protected]>
Signed-off-by: Patryk Miś <[email protected]>
PatrykMis
force-pushed
the
chore/dependency-updates
branch
from
9680342
to
490be08
Compare
Signed-off-by: Patryk Miś <[email protected]>
|
Everything should work as expected now. I made further updates and had to bump minSdk to 26 because of latest TensorFlow. The oldest supported Android version is at API level 30, so keeping minSdk as low as 24 is a nonsense. See also: https://gs.statcounter.com/android-version-market-share |
|
Alright, thank you for your fast response. I'm trying to run the app with your changes on branch |
|
You need Android Studio Jellyfish or later to successfully build Android project after my update. See the Android Studio compatibility information with AGP (Android Gradle Plugin). |
PatrykMis
force-pushed
the
chore/dependency-updates
branch
from
9c310ef
to
357ffa1
Compare
PatrykMis
force-pushed
the
chore/dependency-updates
branch
from
1b7e77d
to
80d84ad
Compare
Signed-off-by: Patryk Miś <[email protected]>
PatrykMis
force-pushed
the
chore/dependency-updates
branch
from
b87bb5e
to
c3c1c07
Compare
* Android Gradle Plugin to v8.4.2 * AndroidX * TensorFlow Lite * Fix `LintOptions` deprecation * Remove clean task: it is already provided by AGP and well-working * Remove Kapt and other plugins and dependencies that are not being used * other dependency reorganizations * remove license clause from build file as it becames highly-customized for this specific app Signed-off-by: Patryk Miś <[email protected]>
Signed-off-by: Patryk Miś <[email protected]>
Signed-off-by: Patryk Miś <[email protected]>
Signed-off-by: Patryk Miś <[email protected]>
Signed-off-by: Patryk Miś <[email protected]>
Signed-off-by: Patryk Miś <[email protected]>
PatrykMis
force-pushed
the
chore/dependency-updates
branch
from
c3c1c07
to
d200aed
Compare
…is/polish_banknotes into chore/dependency-updates
| id 'androidx.navigation.safeargs.kotlin' | ||
| } | ||
|
|
||
| kotlin { |
There was a problem hiding this comment.
@PatrykMis
Sorry for my long-time no answer. Is it necessary or is it only for your usage (lines 7-11)? I cannot compile the app with this change and I don't see the sense to change my environment. Any thoughts?
As a visually impaired user, I want to express my gratitude for the excellent and helpful app! Instead of sending a traditional "thank you" email, I've taken the initiative to contribute to the Android port. While this isn't a comprehensive overhaul, I've made initial updates.
I've ensured that all dependencies are up-to-date, along with making minor code adjustments to align with recent updates. If you welcome pull requests, I am open to performing further code refactoring, including modernizing deprecated code and making improvements for TalkBack and potentially other screen readers.
All additional explanations are inside commits descriptions.