Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr77 fixup #101

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Pr77 fixup #101

wants to merge 8 commits into from

Conversation

fatmcgav
Copy link

This PR takes the changes from #77 and fixes the merge conflicts.

Also added a couple of other little bits:

  • fb0fac5 - Add some additional Makefile targets that I found useful for local dev, and also fix the local dev workflow with TF 0.13
  • 0279dca - Fix failing tests due to parent_project_id not matching

tombuildsstuff and others added 8 commits April 22, 2020 09:23
This is required as of Terraform 0.12, else these are omitted from the state
When Terraform invokes a provider via the Create method, the 'isNew' attribute
will be set - so these calls are superflurious
This makes the drift-detection consistent across all resources, so that
Terraform is able to detect when these resources have been deleted outside
of Terraform and require recreation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants