New Search and Profile Frontend #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement streaming response
saifullah-talukder
changed the title
rathijitpapon
approved these changes
Jun 25, 2024
Comment on lines
+32
to
+33
| - name: AUTH_SECRET | ||
| value: 05mk7ukF/GSG1dHLYVp04Mxa49slQb2W3N9v1aMcRTM= |
There was a problem hiding this comment.
@AsmiKloud these kinds of secrets should probably be retrieved from our secret manager, right? :)
There was a problem hiding this comment.
I see some other ones here as well btw, like the posthog key.
| } | ||
|
|
||
| const text = decoder.decode(value, { stream: true }) | ||
| const lines = text.split('\n').filter(Boolean) |
There was a problem hiding this comment.
True. There is also TextDecoderStream, so that we could decode during streaming and get strings directly.
…-fix Update deployment.yaml
Update service.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore all the changes that are not from the frontend folder. Those changes are from eng-179. Which is already merged.