QGIS3 major update (#41) #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* apply qgis2to3, see #2 * update metadata.txt to qgis3, see #2 * update resources file to qt5, see #2 * fix another qgis2to3 issue, see #2 * Rewriting code for QGIS 3 part 1 Undertaken steps: - importing some modules and classes in due to splitting the original ones (QtGui > QtGui, QtWidget) - renaming some QGIS API 3.x classes Result: - plugin can be started in QGIS 3 - VFK file can be imported * Update README.md * Decoding UTF-8 ad vfkTableModel.py: - in Python 3 no longer needed "prefixes" u'...'/u"..." ad mainApp.py: - problem with decoding the file I found this hack (can't find the source again), but the traceback says the byte can't be decoded - is the encoding truly utf-8? sources: https://timothybramlett.com/Strings_Bytes_and_Unicode_in_Python_2_and_3.html https://medium.com/@andreacolangelo/strings-unicode-and-bytes-in-python-3-everything-you-always-wanted-to-know-27dc02ff2686 * quick and dirty QByteArray fix, see #3 * Completing API functions Functions which run correctly - import - search form (owners excluded) - export (HTML, LaTeX) * add sample data Co-authored-by: luciestara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undertaken steps:
Result:
ad vfkTableModel.py:
ad mainApp.py:
I found this hack (can't find the source again), but the traceback says the byte can't be decoded - is the encoding truly utf-8?
sources:
https://timothybramlett.com/Strings_Bytes_and_Unicode_in_Python_2_and_3.html
https://medium.com/@andreacolangelo/strings-unicode-and-bytes-in-python-3-everything-you-always-wanted-to-know-27dc02ff2686
Functions which run correctly
Co-authored-by: luciestara [email protected]