-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ParentID as an option to Conf Page Create #211
base: main
Are you sure you want to change the base?
Add ParentID as an option to Conf Page Create #211
Conversation
See https://developer.atlassian.com/cloud/confluence/rest/v2/api-group-page/#api-pages-post where parentId is an option for the request.
I GOTTA stop adding this one...
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
+ Coverage 89.19% 89.25% +0.05%
==========================================
Files 154 148 -6
Lines 12044 11626 -418
==========================================
- Hits 10743 10377 -366
+ Misses 659 632 -27
+ Partials 642 617 -25 ☔ View full report in Codecov by Sentry. |
Documentation PR: ctreminiom/go-atlassian-docs#2 |
closing pr due inactivity |
I'm sorry but what activity was needed? I don't see any feedback here and I've been using a custom build of |
What needs to be done to get this merged? Anything I can help with? |
I'm not sure why this received the "breaking-change" label (I VAGUELY recall some comment somewhere with that term but I don't remember where it is and I just re-examined these changes and I don't see how adding a field to the |
Fixes #210 by adding
ParentID
to create page request.See
https://developer.atlassian.com/cloud/confluence/rest/v2/api-group-page/#api-pages-post
where parentId is an option for the request.