-
-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds podman support #732
base: development
Are you sure you want to change the base?
adds podman support #732
Conversation
Creates a dockerfile that can run via podman on fedora/centos/rhel systems with SELinux enabled.
Hi @ohadlevy, Thanks for the contribution! I apologize it has taken me a while to get around to review. I am not familiar with docker myself. The existing docker configuration was contributed by another community member. Could you explain the benefits of this configuration as well as how to use it? |
Hi, The main value (for me) was the ability to run it on my system, the base container that is currently offered does not follow SELinux and my system ended up rejecting the various network configuration changes. another plus (for me again) that I was able to build it using podman vs docker, as docker is slowly phasing out on some common distributions. in order to test it, I've published the image at quay.io/ohadlevy/tuya, so if you are using docker-compose you could simply change the image reference (from tuya:latest to quay.io/ohadlevy/tuya:latest) |
Hi, I originally added the docker-functionality on tuya. The main reason that I used a ubuntu-based image was that I could use install_prereq.sh without problems. I'll try @pdugas approach (#796) with a an alpine-image. @ohadlevy Your image btw. isn't specific to podman, it would work perfectly well with docker, since these buildfiles are interchangeable after OCI (Open Container Initiative). It is just using an fedora-minimal instead of a ubuntu-minmal image inside the container. |
the main issue was with SELinux alerts on my host machine, I assume it depends on the base image (e.g. ubunutu) and usage of host networking. using a fedora based image eliminated that concern. regardless, if alphine works, I'm more than happy :) I actually built it using quay, which is building using docker (I think) but it worked just as well on my local podman instance. |
Hello, Please feel free to ignore this PR, but since I did the work, I thought I'll at least offer it.
I'm running on Fedora as my base machine, and was unable to run the container due to selinux limitations, I ended up rebuilding a new container based on fedora.