Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All assumptions applied to functions of time should be transferred to their discrete versions #215

Open
moorepants opened this issue Aug 29, 2024 · 1 comment
Labels

Comments

@moorepants
Copy link
Member

The generation of discrete variables looks like:

        self.previous_discrete_state_symbols = \
            tuple([sm.Symbol(f.__class__.__name__ + 'p', real=True)
                   for f in self.state_symbols])

This sets a real=True assumption on each new discrete symbol but any other assumptions that may have been applied to the continuous symbol would be lost. This can have an unexpected effect when the Jacobian is calculated if some assumptions would change the output of the Jacobian wrt to any discrete symbol.

@moorepants
Copy link
Member Author

A related issue is that the CSE variables don't have the assumptions of the expressions they replace. See #216 for related info.

@moorepants moorepants added the bug label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant