Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capacities and occupancies for service and program occurrences #117

Open
wants to merge 46 commits into
base: master
Choose a base branch
from

Conversation

htysc
Copy link
Collaborator

@htysc htysc commented Mar 2, 2024

No description provided.

@htysc htysc changed the base branch from master to client-outcomes March 2, 2024 02:08
@htysc htysc force-pushed the capacities branch 3 times, most recently from 2603de9 to 92e6d45 Compare March 2, 2024 02:43
@htysc htysc changed the base branch from client-outcomes to master March 5, 2024 17:50
@htysc htysc changed the base branch from master to service-waitlist March 5, 2024 17:51
@htysc htysc changed the base branch from service-waitlist to master March 5, 2024 17:55
@htysc
Copy link
Collaborator Author

htysc commented Mar 6, 2024

@Damon-D-Ma The occupancy code requires a waitlist with a queue that has three methods like these:

  • push(registration) - Insert this service/program registration into the waitlist queue
  • pop() - Remove the next element of the queue
  • remove(registrationId) - Remove the element with the given ID from the queue (from wherever it is, even the middle of the queue)

So the serviceWaitlist will need to have a queue of serviceRegistrations instead of clients.

There are four TODOs relating to waitlists in backend/services/genericData/programRegistration.js (and four very similar ones in backend/services/genericData/serviceRegistration.js). Once these are done we'll be much closer to completing the occupancy functionality.

frontend/src/components/serviceWaitlist/ServiceWaitlist.js Outdated Show resolved Hide resolved
frontend/src/routes.js Outdated Show resolved Hide resolved
frontend/src/components/ServiceWaitlists.js Outdated Show resolved Hide resolved
backend/services/genericData/waitlistEntry.js Outdated Show resolved Hide resolved
backend/services/genericData/waitlistEntry.js Outdated Show resolved Hide resolved
Damon-D-Ma and others added 7 commits March 15, 2024 11:34
For some reason these files didn't want to push.
Nearly identical to that of "serviceWaitlist", however it stores a programOccurrence instead of a serviceOccurrence, and a list of "programWaitlistEntry" instead of a "waitlistEntry". There are two different classes of models for program and service waitlists because it would not make sense to give both a program AND service occurrence to the same model and have one of these values be blank/null depending on which of the two is using it.
@htysc htysc marked this pull request as ready for review March 18, 2024 19:12
@htysc
Copy link
Collaborator Author

htysc commented Mar 18, 2024

@LesterLyu The part relating to service occurrences is complete and partially tested.

@htysc htysc requested a review from LesterLyu March 20, 2024 17:39
@htysc
Copy link
Collaborator Author

htysc commented Mar 20, 2024

Ready to be reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants