Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py source consistency using isort and pyupgrade tools, rm unused imports #163

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Oct 14, 2022

This PR is further clean-up, mostly automated with a few manual edits. Using isort, pyupgrade, also flake8 --select F401 to identify unused imports.

Also remove unused shebangs on non-executable module and test files.

Also remove unused shebangs on non-executable module and test files
@mdpiper
Copy link
Member

mdpiper commented Feb 3, 2023

@mwtoews Thank you for this contribution, and I apologize for getting to it so late!

@mcflugen I'm going to merge this PR despite the failing tests, since the changes here don't have any bearing on the tests. I've identified the reasons for the failing tests -- #162, #164, and permamodel/permamodel#72 -- and I have a workaround for them in a separate branch.

@mdpiper mdpiper merged commit b462904 into csdms:master Feb 3, 2023
@mwtoews mwtoews deleted the isort-pyupgrade-etc branch February 4, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants