Add IO to OpenEducation methodology #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/reading
teodutu
added
the
needs-rendering
Mihnea0Firoiu
force-pushed
the
Mihnea0Firoiu/IO
branch
from
a351b9b
to
d84d43a
Compare
teodutu
added
needs-rendering
teodutu
requested changes
Aug 11, 2024
There was a problem hiding this comment.
Check my comments to see some easy first fixes and also why the build fails. Then when it passes I'll make a more in-depth review.
- Move the task descriptions from the
reading/files to each task'sREADME.md - Remove references to the common makefiles (
.../common/makefile/*.mk). Copy their content to each makefile that includes them so the tasks don't depend on outside resources.
chapters/io/client-server-model/drills/tasks/client-server/README.md
Outdated
Show resolved
Hide resolved
chapters/io/io-internals/drills/tasks/buffering/support/libc_buffering.c
Outdated
Show resolved
Hide resolved
chapters/io/io-internals/drills/tasks/buffering/support/printf_buffering.c
Outdated
Show resolved
Hide resolved
chapters/io/io-internals/drills/tasks/buffering/support/no_buffering.c
Outdated
Show resolved
Hide resolved
chapters/io/local-io-in-action/drills/tasks/simple-file-operations/support/Makefile
Outdated
Show resolved
Hide resolved
chapters/io/pipes/drills/tasks/receive-challenges/support/Makefile
Outdated
Show resolved
Hide resolved
Mihnea0Firoiu
force-pushed
the
Mihnea0Firoiu/IO
branch
from
d84d43a
to
18a5278
Compare
teodutu
added
needs-rendering
teodutu
reviewed
Sep 29, 2024
chapters/io/file-mappings/drills/tasks/file-mappings/support/benchmark_cp.sh
Outdated
Show resolved
Hide resolved
teodutu
requested changes
Sep 29, 2024
chapters/io/remote-io/drills/tasks/receive-challenges/support/Makefile
Outdated
Show resolved
Hide resolved
chapters/io/remote-io/drills/tasks/send-receive/support/receiver.py
Outdated
Show resolved
Hide resolved
Alex-deVis
force-pushed
the
Mihnea0Firoiu/IO
branch
from
18a5278
to
d5907ce
Compare
Alex-deVis
added
needs-rendering
|
Published at https://cs-pub-ro.github.io/operating-systems/75/ |
|
@razvand, since I also made changes to the content itself, I think you should also review this. |
Alex-deVis
force-pushed
the
Mihnea0Firoiu/IO
branch
6 times, most recently
from
5fd9558
to
7e8cb71
Compare
Alex-deVis
force-pushed
the
Mihnea0Firoiu/IO
branch
9 times, most recently
from
af7d673
to
965059c
Compare
github-actions
bot
added
area/guides
Alex-deVis
force-pushed
the
Mihnea0Firoiu/IO
branch
from
965059c
to
c0a25c0
Compare
Alex-deVis
added
needs-rendering
|
Published at https://cs-pub-ro.github.io/operating-systems/75/ |
Tasks and guides are stored in tasks/<task>/README.md, but are referenced as <task.md> for simplicity. This commit accounts for this when solving links. Signed-off-by: Alex Apostolescu <[email protected]>
Previously, only links from labs were rerouted. This commit updates the links from all file types, namely: guides, tasks, questions, reading, and media. Signed-off-by: Alex Apostolescu <[email protected]>
Questons are media files are placed in directories on their own, on the same level. This commit accounts for this when generating the .view files, and prepends '../' to media links in question files. Signed-off-by: Alex Apostolescu <[email protected]>
Using greedy regexes collapses consecutive links when solving them e.g. [a](b) [c](d) gets collapsed to [a](d). This commits prevents this using non-greedy regexes. Signed-off-by: Alex Apostolescu <[email protected]>
Show links that do not match expected patterns after solving references. Signed-off-by: Alex Apostolescu <[email protected]>
This commit restructures the IO chapter according to OpenEdu methodology. This comprises of: - refactoring and changing the order of chapters - generating support files from solution - breaking arena into smaller sections - fixing Makefiles from tasks to be self-contained Signed-off-by: Mihnea Firoiu <[email protected]> Signed-off-by: Alex Apostolescu <[email protected]> solve checkpatch
Alex-deVis
force-pushed
the
Mihnea0Firoiu/IO
branch
from
c0a25c0
to
531f0a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite Checklist
Description of changes
Align the IO course to the OpenEdu methodology.
Change the content of laboratories and change the "storyline" to:
Besides these, in
quides/you can find adjacent topics not mandatory to finish the labs, such asfile-descriptor table and open file table,file-mappings,kernel caching, andsendfile benchmarking.