-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added arm directory to exercise 3 #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ummthespruce
Thanks for this PR, I left a review for what needs to be changed.
It would be great to make the changes and then request my review again.
content/chapters/software-stack/lab/support/basic-syscall/arm/Makefile
Outdated
Show resolved
Hide resolved
content/chapters/software-stack/lab/support/basic-syscall/arm/hello.s
Outdated
Show resolved
Hide resolved
content/chapters/software-stack/lab/support/basic-syscall/arm/hello.s
Outdated
Show resolved
Hide resolved
content/chapters/software-stack/lab/support/basic-syscall/arm/hello.s
Outdated
Show resolved
Hide resolved
content/chapters/software-stack/lab/support/basic-syscall/arm/hello.s
Outdated
Show resolved
Hide resolved
Also, it would be great to change the commit message, to something like this: Add arm skeleton from basic-syscall exercise Signed-off-by: YOUR_NAME <YOUR_EMAIL> |
Hi, @ummthespruce, this PR addresses issue #4. Add this to the PR description using a closing keyword: "Closes #4". You should squash all of your commits, sign the resulting commit, and force-push it. This should get rid of the checkpatch errors. |
@ummthespruce Please address what @Alex-deVis said. |
@ummthespruce
After this, you can follow this tutorial in order to squash your commits into a single commit. In the final phase, you should have a single commit merged into the main branch. After you rebase your branch and apply a single commit make sure to put the right commit message as I mentioned above, this should work with:
|
78a5580
to
086b7c8
Compare
No description provided.