Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added arm directory to exercise 3 #5

Closed
wants to merge 0 commits into from

Conversation

ummthespruce
Copy link

No description provided.

@github-actions github-actions bot added area/code Update or new source code support / solution files topic/software-stack Related to "Software Stack" chapter kind/new New content / item labels Oct 17, 2023
Copy link
Member

@gabrielmocanu gabrielmocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ummthespruce
Thanks for this PR, I left a review for what needs to be changed.
It would be great to make the changes and then request my review again.

@gabrielmocanu
Copy link
Member

Also, it would be great to change the commit message, to something like this:
software-stack/lab: Add arm implementation for basic-syscall exercise

Add arm skeleton from basic-syscall exercise

Signed-off-by: YOUR_NAME <YOUR_EMAIL>

@gabrielmocanu gabrielmocanu self-assigned this Oct 18, 2023
@Alex-deVis
Copy link

Hi, @ummthespruce, this PR addresses issue #4. Add this to the PR description using a closing keyword: "Closes #4".

You should squash all of your commits, sign the resulting commit, and force-push it. This should get rid of the checkpatch errors.

@gabrielmocanu
Copy link
Member

@ummthespruce Please address what @Alex-deVis said.
If you need any help, please let us know.

@gabrielmocanu gabrielmocanu added the student-contrib Fix or improvement made by a student label Oct 24, 2023
@gabrielmocanu
Copy link
Member

@ummthespruce
First configure your name and email.

git config --global user.name "Your Name"
git config --global user.email "your email"

After this, you can follow this tutorial in order to squash your commits into a single commit. In the final phase, you should have a single commit merged into the main branch.

After you rebase your branch and apply a single commit make sure to put the right commit message as I mentioned above, this should work with:

git commit --amend -s
  • -s flag will add your signature
  • --amend will open your editor with the current commit message to be able to edit it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code Update or new source code support / solution files kind/new New content / item student-contrib Fix or improvement made by a student topic/software-stack Related to "Software Stack" chapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants