Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chapters/intro-computer-architecture: Add content #13

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cristian-vijelie
Copy link
Member

Prerequisite Checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Updated relevant documentation (if needed).

Description of changes

Add content for the 3rd lab, Compiling and Linking

@cristian-vijelie cristian-vijelie marked this pull request as draft March 24, 2024 18:48
Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made an initial pass. Apply these changes to the rest of this file and to others that you'll add in this PR.

@@ -14,7 +14,7 @@ Content is located in the `chapters/` folder.
It currently consists of 5 chapters:

- [Memory Layout](chapters/memory-layout/)
- [Introduction to Computer Architecture](content/intro-computer-architecture/)
- [Introduction to Computer Architecture](chapters/intro-computer-architecture/)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +17 to +18
* comment removal
* expansion of preprocessor directives (the ones that begin with `#`), like `#define`, `#include`, `#pragma`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* comment removal
* expansion of preprocessor directives (the ones that begin with `#`), like `#define`, `#include`, `#pragma`.
- comment removal
- expansion of preprocessor directives (the ones that begin with `#`), like `#define`, `#include`, `#pragma`.

Use dashes, not asterisks for unnumbered lists.

With `gcc`, this step can be run using the `-E` flag.
The output file will have the `.i` extension.
```bash
$ gcc -E main.c -o main.i
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$ gcc -E main.c -o main.i
student@hsi:~$ gcc -E main.c -o main.i

Add generic prompts whenever there's a command that's not supposed to be run from a specific folder (such as a task or a guide).

@github-actions github-actions bot added area/reading Update to reading material topic/intro-computer-architecture Related to the "Intro to Computer Architecture" chapter kind/new New content / item labels Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/reading Update to reading material kind/new New content / item topic/intro-computer-architecture Related to the "Intro to Computer Architecture" chapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants