Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Reversion metrics #466

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

feat: Reversion metrics #466

wants to merge 21 commits into from

Conversation

bsamuels453
Copy link

@bsamuels453 bsamuels453 commented Aug 28, 2024 •
edited
Loading

image

@bsamuels453 bsamuels453 changed the title [Draft] Reversion metrics feat: Reversion metrics Aug 28, 2024
0xalpharush
0xalpharush reviewed Aug 29, 2024
View reviewed changes
fuzzing/fuzzer.go Outdated Show resolved Hide resolved
0xalpharush
0xalpharush reviewed Aug 29, 2024
View reviewed changes
fuzzing/fuzzer.go Outdated Show resolved Hide resolved
0xalpharush
0xalpharush reviewed Aug 29, 2024
View reviewed changes
fuzzing/fuzzer.go Outdated Show resolved Hide resolved
@0xalpharush
Copy link
Member

0xalpharush commented Aug 29, 2024 •
edited
Loading

Could we pick one phrase like "Revert Statistics" and use it consistently right now there's three or four ways and it'll be easier to search in the codebase for if we use the same terms?

@bsamuels453
Copy link
Author

Could we pick one phrase like "Revert Statistics" and use it consistently right now there's three or four ways and it'll be easier to search in the codebase for if we use the same terms?

agree, I've refactored this to call the component the "reversion reporter"

@bsamuels453 bsamuels453 changed the title feat: Reversion metrics [Draft] feat: Reversion metrics Aug 29, 2024
@bsamuels453 bsamuels453 changed the title [Draft] feat: Reversion metrics feat: Reversion metrics Aug 29, 2024
@bsamuels453
Copy link
Author

@0xalpharush I'm satisfied with how the feature is working; this PR is ready for final review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xenomega Xenomega Awaiting requested review from Xenomega Xenomega is a code owner

@anishnaik anishnaik Awaiting requested review from anishnaik anishnaik is a code owner

@0xalpharush 0xalpharush Awaiting requested review from 0xalpharush 0xalpharush is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsamuels453 @0xalpharush