Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add library support for crytic-compile platform #183

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0xalpharush
Copy link
Contributor

@0xalpharush 0xalpharush commented Jul 28, 2023

Closes #139

The solc export format now has the dependencies resolved in crytic/crytic-compile#480 so it's possible to just deploy the necessary libraries in order for each contract. For recursive dependencies i.e. a library depends on a library, the previously deployed libraries are looked through for matching placeholders.

  • Address TODO by refactoring duplicate deployment code
  • Decide whether solc/truffle compilation needs to be updated or dropped
  • See if this works for Foundry/ Hardhat
  • Add ABI info from dependencies wherever it's used to fix tracing function and event signatures
  • Consider impact of duplicate contract or library names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve library support
1 participant