Add Nix support #143
Open
Add Nix support #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bohendo
commented
May 2, 2023
Comment on lines
+24
to
+36
| solc-select = pkgs.python39Packages.buildPythonPackage (pyCommon // { | ||
| pname = "solc-select"; | ||
| version = "1.0.3"; | ||
| src = builtins.fetchGit { | ||
| url = "git+ssh://[email protected]/crytic/solc-select"; | ||
| rev = "97f160611c39d46e27d6f44a5a61344e6218d584"; | ||
| }; | ||
| propagatedBuildInputs = with pkgs.python39Packages; [ | ||
| packaging | ||
| setuptools | ||
| pycryptodome | ||
| ]; | ||
| }); |
There was a problem hiding this comment.
In-line addition of nix support to solc-select & other packages that don't feature a flake.nix file yet. If/when they do, these pieces of config can move into their respective repos & can be removed from this project.
In the meantime, they allow medusa to depend on a specific commit of crytic-compile, etc
|
bohendo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once merged to the default branch, this PR should allow anyone with nix installed to run
nix run github:crytic/medusato use the medusa tool without installing anything globally. Kind of like a single-serving virtualenv. The first time this is run, it'll take some time as medusa's dependencies (egslither) are downloaded & the project is built, but subsequent runs will start almost instantly without requiring any further downloads. More info renix run.Allows global installation of medusa with:
nix build && nix-env -i ./result. Thismedusainstallation is hooked up to a new copy of required dependencies, so it'll take care of the slither dependency if not already present but w/out any risk of conflict w existing globalslitherinstallation.Also provides a developer environment via
nix developwhich opens a shell that includes basic golang tools & other dependencies needed to build & run tests.This is entirely opt-in, it uses the rest of the repo's config (eg
go.mod) rather than attempting to replace it. If you don't want to fiddle withnix, then you can ignore these new files & do the same thing you've always done.