Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

232 dup: feat: add new platforms to "--supported-platforms" #347

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

bohendo
Copy link
Contributor

@bohendo bohendo commented Jan 6, 2023

Closes #231 I updated the wiki. also added it to the CLI since I regularly check what chains crytic-compile supports when using slither and find that useful. This PR adds non-mainnet chains with etherscan-like explorers to supported platforms. (I also fixed the spelling of mainet to mainnet)

Current output of crytic-compile --supported-platforms

INFO:CryticCompile:
- solc: https://github.com/ethereum/solidity
- Truffle: https://github.com/trufflesuite/truffle
- Embark: https://github.com/embarklabs/embark
- Dapp: https://github.com/dapphub/dapptools
- Etherlime: https://github.com/LimeChain/etherlime
- Etherscan: https://etherscan.io/
- vyper: https://github.com/vyperlang/vyper
- Waffle: https://github.com/EthWorks/Waffle
- Brownie: https://github.com/iamdefinitelyahuman/brownie
- Solc-json: https://solidity.readthedocs.io/en/latest/using-the-compiler.html#compiler-input-and-output-json-description
- Buidler: https://github.com/nomiclabs/buidler
- Hardhat: https://github.com/nomiclabs/hardhat
- Standard: https://github.com/crytic/crytic-compile
- Archive: https://github.com/crytic/crytic-compile

After this PR

INFO:CryticCompile:
- solc: https://github.com/ethereum/solidity
- Truffle: https://github.com/trufflesuite/truffle
- Embark: https://github.com/embarklabs/embark
- Dapp: https://github.com/dapphub/dapptools
- Etherlime: https://github.com/LimeChain/etherlime
- Arbitrum: https://arbiscan.io
- Arbitrum Testnet: https://testnet.arbiscan.io
- Avalanche: https://snowtrace.io
- Avalanche Testnet: https://testnet.snowtrace.io
- Binance Smart Chain: https://bscscan.com
- Binance Smart Chain Testnet: https://testnet.bscscan.com
- Etherscan: https://etherscan.io/
- Fantom: https://ftmscan.com
- Goerli: https://goerli.etherscan.io
- Kovan: https://kovan.etherscan.io
- Polygon: https://polygonscan.com
- Rinkeby: https://rinkeby.etherscan.io
- Ropsten: https://ropsten.etherscan.io
- Tobalaba: https://tobalaba.etherscan.io
- vyper: https://github.com/vyperlang/vyper
- Waffle: https://github.com/EthWorks/Waffle
- Brownie: https://github.com/iamdefinitelyahuman/brownie
- Solc-json: https://solidity.readthedocs.io/en/latest/using-the-compiler.html#compiler-input-and-output-json-description
- Buidler: https://github.com/nomiclabs/buidler
- Hardhat: https://github.com/nomiclabs/hardhat
- Standard: https://github.com/crytic/crytic-compile
- Archive: https://github.com/crytic/crytic-compile

closes #232

@montyly
Copy link
Member

montyly commented Jan 9, 2023

I am not sure about this solution. It looks like we are using a short term solution for a non-critical/blocking fix, that we know will require a refactoring.

If we do so, we are likely to not prioritizing the proper fix, and this will increase our tech debt, and might block us in the future.

I would be in favor to implement the solution from #232 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants