Array use after pop front detector #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarunbhm
changed the title
smonicas
reviewed
Sep 18, 2023
Comment on lines
76
to
78
| let message = format!( | ||
| "An array is used after removing elements from it in the function {}", | ||
| &function.name() |
There was a problem hiding this comment.
It would be nice to print the array ID in sierra
Comment on lines
108
to
131
| || self.check_calls( | ||
| compilation_unit, | ||
| function, | ||
| bad_array, | ||
| &mut function.private_functions_calls(), | ||
| ) | ||
| || self.check_calls( | ||
| compilation_unit, | ||
| function, | ||
| bad_array, | ||
| &mut function.library_functions_calls(), | ||
| ) | ||
| || self.check_calls( | ||
| compilation_unit, | ||
| function, | ||
| bad_array, | ||
| &mut function.external_functions_calls(), | ||
| ) | ||
| || self.check_calls( | ||
| compilation_unit, | ||
| function, | ||
| bad_array, | ||
| &mut function.events_emitted(), | ||
| ); |
There was a problem hiding this comment.
I think you can make this into a single call to check_calls by chaining the iterators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review.