seperate pr for felt252 detector

crytic · Sep 5, 2023 · c1779da · c1779da
1 parent 5eafe2b
commit c1779da
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/detectors/felt252_overflow.rs b/src/detectors/felt252_overflow.rs
@@ -15,19 +15,19 @@ pub struct Felt252Overflow {}
 
 impl Detector for Felt252Overflow {
     fn name(&self) -> &str {
-        "felt252-unsafe-arithmetic"
+        "felt252-overflow"
     }
 
     fn description(&self) -> &str {
-        "Detect felt252 arithmetic overflow/underflow with user-controlled params"
+        "Detect felt252 arithmetic overflow with user-controlled params"
     }
 
     fn confidence(&self) -> Confidence {
         Confidence::Medium
     }
 
     fn impact(&self) -> Impact {
-        Impact::Medium
+        Impact::High
     }
 
     fn run(&self, core: &CoreUnit) -> Vec<Result> {
@@ -116,7 +116,7 @@ impl Felt252Overflow {
         // Not tainted by any parameter, but still uses felt252 type
         if tainted_by.is_empty() {
             let msg = format!(
-                "The function {} uses the felt252 operation {}, which is not overflow/underflow safe",
+                "The function {} uses the felt252 operation {}, which is not overflow safe",
                 &name, libfunc
             );
             results.push(Result {
@@ -127,7 +127,7 @@ impl Felt252Overflow {
             });
         } else {
             let msg = format!(
-                    "The function {} uses the felt252 operation {} with the user-controlled parameters: {}, which is not overflow/underflow safe",
+                    "The function {} uses the felt252 operation {} with the user-controlled parameters: {}, which is not overflow safe",
                     &name,
                     libfunc,
                     taints