Constrain CI triggers

[0xPhaze]

Some action triggers can be further restricted. Re #214

[elopez]

I left some notes inline 👍 Maybe instead of duplicating the manticore workflow, we could convert it into a reusable workflow: https://docs.github.com/en/actions/using-workflows/reusing-workflows

[elopez]

Can you also add the echidna yaml configs, and the workflow yaml file itself?

[elopez]

This should also include things like images, css and other static/ resources

[0xPhaze]

My thinking was that if a new static resource is added, it must be referenced somewhere in the .md, right? Otherwise it's just part of the github repo.

[elopez]

the resources could be edited on their own (e.g modify a diagram, or update the CSS)

[0xPhaze]

ah I see, I was somehow expecting them to be directly linked to the github-hosted resources. Maybe then it's easier to only exclude code files (if #264 is merged). Otherwise, I'll just keep it unrestricted for now...

[elopez]

This env variable is now unused, so it can be dropped

[elopez]

This env variable is unused, so it can be dropped

[0xPhaze]

I left some notes inline 👍 Maybe instead of duplicating the manticore workflow, we could convert it into a reusable workflow: https://docs.github.com/en/actions/using-workflows/reusing-workflows

I'm not so familiar with workflows yet. If we want to keep them in one file like before, do you mind showing me how?

[elopez]

I'm not so familiar with workflows yet. If we want to keep them in one file like before, do you mind showing me how?

With reusable workflows you'd still need separate files, but at least the steps would not be duplicated. It may not be worth the effort though, these workflows are rather small. Untested sample below, refer to the docs if you want to try it and it doesn't work 😅

manticore.yml (similar for slither.yml)

name: Run Manticore tests

on:
  push:
    paths:
      - ".github/workflows/manticore.yml"
      - "program-analysis/manticore/**/*.py"
    branches:
      - master
  pull_request:
    paths:
      - ".github/workflows/manticore.yml"
      - "program-analysis/manticore/**/*.py"
  schedule:
    # run CI every day even if no PRs/merges occur
    - cron: "0 12 * * *"

jobs:
  tests:
    uses: ./.github/workflows/python-test.yml
    with:
      tool: manticore
    secrets: inherit

python-test.yml

on:
  workflow_call:
    inputs:
      tool:
        required: true
        type: string

jobs:
  tests:
    runs-on: ubuntu-22.04
    strategy:
      fail-fast: false
    steps:
      - uses: actions/checkout@v3
      - name: Set up Python 3.8
        uses: actions/setup-python@v4
        with:
          python-version: 3.8
      - name: Install dependencies
        run: |
          pip install solc-select
          solc-select install 0.5.11
          solc-select use 0.5.11
      - name: Run Tests
        run: |
          bash program-analysis/${{ inputs.tool }}/scripts/gh_action_test.sh

[0xPhaze]

I guess I'll leave it as is for now. We might want to change it when we get more CI workflows in the future.