Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin output should regard config.root #759

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

intellild
Copy link

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2023

🦋 Changeset detected

Latest commit: fc46cac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@crxjs/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
vite-plugin-docs ⬜️ Ignored (Inspect) Visit Preview Jun 28, 2024 7:07am

@intellild intellild changed the title plugin output should regard to config.root plugin output should regard config.root Jul 25, 2023
Copy link
Contributor

@jacksteamdev jacksteamdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix itself looks good to me, thanks for the contribution. We can merge after the following are completed.

Tasks before merging

  • Verify that it works on Windows
  • Add an e2e test

packages/vite-plugin/src/node/fileWriter.ts Outdated Show resolved Hide resolved
@jacksteamdev jacksteamdev added awaiting-feedback Further information is requested vite-plugin Related to Vite plugin labels Jan 14, 2024
@intellild
Copy link
Author

Sorry for the late, migrated to posix path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-feedback Further information is requested vite-plugin Related to Vite plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants