Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Add Evict operator #54

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Feb 3, 2020

Resolves #18

Implementation of the evict operator - based on #47

Status: works on my machine.... 😆

Follow ups and improvements

  • Support metrics endpoint
  • Setup helm chart

Open questions

  • Which logger to use? klog vs (logrus)[github.com/sirupsen/logrus]
  • Should we do anything with "tainted" jobs or daemon-sets ?

@alpe
Copy link
Contributor Author

alpe commented Feb 24, 2020

I am sorry that this PR is WIP for a while already. I am busy with other work and have not found the time to finish the tests and remaining todos, yet. I will do but feel free to close the PR for now to keep the list of PRs clean. ⌛️

@dustin-decker
Copy link
Contributor

No worries, @alpe, take your time. All of your contributions are appreciated. I'll try to get the policy end of this sorted at some point, but I have been busy with a few things as well.

@dustin-decker
Copy link
Contributor

Another usecase came up today for this: A maxAge annotation for Pods. Pods would get evicted after passing the duration specified.

This is handy for triggering re-provisioning of certificates, and also just enforce good hygiene and ensure that disruptions are tolerable.

@alpe alpe marked this pull request as ready for review August 6, 2020 16:10
@alpe
Copy link
Contributor Author

alpe commented Aug 6, 2020

This PR was WIP for quite some time. I think it would be better if we can get the code into master and work on improvements together. There are some open questions and extensions that can be addresses by separate and smaller PRs later.

For testing the evictor, please see 7bc0b34 for a configuration example. I have reverted the commit as it requires some testing.

@dustin-decker
Copy link
Contributor

Sounds good to me. I'll take a look at doing that. Thanks for the update @alpe.

@mark-adams
Copy link
Contributor

👋 The k-rail project has been deprecated and is no longer under active development. We recommend taking a look at OPA Gatekeeper to see if it might meet your needs going forward.

Thanks for your contribution(s) to the project!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[FR] evict tainted pods after period
3 participants