Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

designate: allow worker on cluster. #2104

Merged
merged 2 commits into from
Jun 12, 2019

Conversation

sjamgade
Copy link
Contributor

[1] suggests that workers are there for designate-central to get work
done. So having more of them is a good idea.
A worker does not really have an idea of api so no vip or haproxy
config is required.

1 - https://docs.openstack.org/designate/rocky/contributor/architecture.html

@sjamgade
Copy link
Contributor Author

either way admins could have them deployed on multiple nodes without necessarily calling it HA

@jgrassler
Copy link
Contributor

Feel free to review but please do not merge, yet. We'll give this a spin in a QA environment first.

@cmurphy
Copy link
Contributor

cmurphy commented Apr 15, 2019

If it can already be deployed individually to multiple nodes why does it need to be part of a cluster?

@dirkmueller
Copy link
Contributor

@cmurphy count is set to 1, so only one node can be assigned atm

@jgrassler
Copy link
Contributor

It makes sense to have it running on all cluster nodes if an HA cluster is available (it is just a RabbitMQ driven backend server after all). This pull request is just a shortcut for convenience.

jgrassler added a commit to jgrassler/crowbar-openstack that referenced this pull request Apr 15, 2019
This reverts commit 64e7ad9.

We've are very close to the release and have multiple pull requests still open
for Designate:

* crowbar#2095
* crowbar#2104
* crowbar#2105
* SUSE-Cloud/doc-cloud#931

There are way too many question marks on this so I am
switching the barclamp back to invisible mode. Lets get these
pull requests squared away carefully and without the rush of
imminent release.
cmurphy
cmurphy previously approved these changes Apr 15, 2019
@vuntz
Copy link
Member

vuntz commented Apr 16, 2019

Am I reading correctly that the service will use provider Chef::Provider::CrowbarPacemakerService if use_crowbar_pacemaker_service ?

If yes, this needs to be fixed and systemd needs to be used instead. You can compare with how it's done for other services (like glance), which has a similar code structure for the cookbook.

@guangyee
Copy link
Contributor

guangyee commented May 6, 2019

It should be on all cluster nodes right, unless Designate can tolerate single-point-of-failure for the workers node? fwiw, looking at the Ardana input models, it appears Designate workers are running on all the clustered nodes.

Sumit Jamgade added 2 commits May 9, 2019 15:01
[1] suggests that workers are there for designate-central to get work
done. So having more of them is a good idea.
A worker does not really have an idea of api so no vip or haproxy
config is required.

1 - https://docs.openstack.org/designate/rocky/contributor/architecture.html
@dirkmueller
Copy link
Contributor

@guangyee thats what the code does now.

sjamgade pushed a commit to sjamgade/crowbar-openstack that referenced this pull request May 16, 2019
This reverts commit 64e7ad9.

We've are very close to the release and have multiple pull requests still open
for Designate:

* crowbar#2095
* crowbar#2104
* crowbar#2105
* SUSE-Cloud/doc-cloud#931

There are way too many question marks on this so I am
switching the barclamp back to invisible mode. Lets get these
pull requests squared away carefully and without the rush of
imminent release.
@cmurphy
Copy link
Contributor

cmurphy commented May 29, 2019

Is it expected that the ha_want_designate job is failing?

@sjamgade
Copy link
Contributor Author

SUSE-Cloud/automation#3443 and https://jira.suse.com/browse/SOC-9342 is needed for tempest (smoke) test to pass.
thats why the ha_want_designate job is failing.

@sjamgade sjamgade merged commit b92e4f9 into crowbar:master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants