Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Private DNS Resolver Inbound Endpoint azurerm_private_dns_resolver_inbound_endpoint #810

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add Private DNS Resolver Inbound Endpoint azurerm_private_dns_resolver_inbound_endpoint #810

wants to merge 11 commits into from

Conversation

faizan-younus
Copy link

Description of your changes

Added the resource azurerm_private_dns_resolver_inbound_endpoint which is already available in the terraform release.

Fixes #

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

The code was tested locally with a KIND cluster and by running the provider out-of-cluster using make run:

cat <<EOF | kubectl apply -f -
apiVersion: network.azure.upbound.io/v1beta1
kind: PrivateDNSResolverInboundEndpoint
metadata:
  annotations:
    meta.upbound.io/example-id: network/v1beta1/privatednsresolverinboundendpoint
  labels:
    testing.upbound.io/example-name: example
  name: example
spec:
  providerConfigRef:
    name: default
  forProvider:
    ipConfigurations:
    - privateIpAllocationMethod: Dynamic
      subnetId: "<example-subnet-id>"
    location: "West Europe"
    privateDnsResolverId: "<example-private-dns-resolver>"
EOF

Results

Screenshot 2024-09-04 at 10 20 20

faizan-younus and others added 7 commits September 4, 2024 15:21
@faizan-younus
adding inboundendpoint
70059ed 
Signed-off-by: faizan-younus <[email protected]>
@turkenf @faizan-younus
Bump upjet to the commit 2e361ad3b6e6
dc8fbdc 
Signed-off-by: Fatih Türken <[email protected]>
Signed-off-by: faizan-younus <[email protected]>
@renovate @faizan-younus
Update actions/upload-artifact digest to 834a144
660dbf5 
Signed-off-by: faizan-younus <[email protected]>
@drew0ps @faizan-younus
Added azurerm_data_protection_backup_policy_kubernetes_cluster
ce66cea 
Adapted examples-generated/dataprotection/v1beta1/backuppolicykubernetescluster.yaml to new format. Some fields are now maps instead of arrays.

Adapted  examples/dataprotection/v1beta1/backuppolicykubernetescluster.yaml, restored the generated one

Signed-off-by: drew0ps <[email protected]>
@drew0ps @faizan-younus
Restored examples-generated/dataprotection/v1beta1/backuppolicykubern…
41dcea8 
…etescluster.yaml to the generated version

Adds an rg name more unique to the use case
Adds a backup vault name more specific to the use case
Adds a k8s backup policy name more specific to the use case
Co-authored-by: Fatih Türken <[email protected]>
Signed-off-by: drew0ps <[email protected]>

Signed-off-by: faizan-younus <[email protected]>
@renovate @faizan-younus
Update actions/upload-artifact digest to 5076954
5f8edd3 
Signed-off-by: faizan-younus <[email protected]>
@faizan-younus
adding example privatednsresolverinboundendpoint.yaml
cc60a14 
Signed-off-by: faizan-younus <[email protected]>
@faizan-younus faizan-younus force-pushed the feature/privatednsresolverinboundendpoint branch from bc25bb9 to cc60a14 Compare September 4, 2024 13:36
@faizan-younus
Copy link
Author

/test-examples="examples/network/v1beta1/privatednsresolverinboundendpoint.yaml"

1 similar comment
@drew0ps
Copy link
Contributor

drew0ps commented Sep 4, 2024

/test-examples="examples/network/v1beta1/privatednsresolverinboundendpoint.yaml"

@drew0ps
Copy link
Contributor

drew0ps commented Sep 4, 2024 •
edited
Loading

@faizan-younus The automated tests wont start because you are not marked as a contributor yet. Once this is merged you become a contributor you can also kick off the uptest pipelines with the command

@faizan-younus
removing extra line
21e30b8 
Signed-off-by: faizan-younus <[email protected]>
@drew0ps
Copy link
Contributor

drew0ps commented Sep 6, 2024

/test-examples="examples/network/v1beta1/privatednsresolverinboundendpoint.yaml"

@turkenf turkenf mentioned this pull request Sep 6, 2024
Closed
1 task
@faizan-younus faizan-younus mentioned this pull request Sep 10, 2024
Open
@faizan-younus
Merge branch 'main' of github.com:faizan-younus/provider-upjet-azure …
3c606a4 
…into feature/privatednsresolverinboundendpoint

Signed-off-by: faizan-younus <[email protected]>
@drew0ps
Copy link
Contributor

drew0ps commented Sep 23, 2024

/test-examples="examples/network/v1beta1/privatednsresolverinboundendpoint.yaml"

@faizan-younus
changing references
808d773 
Signed-off-by: faizan-younus <[email protected]>
@drew0ps
Copy link
Contributor

drew0ps commented Sep 26, 2024

/test-examples="examples/network/v1beta1/privatednsresolverinboundendpoint.yaml"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

@turkenf turkenf Awaiting requested review from turkenf turkenf is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faizan-younus @drew0ps @turkenf