Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Add associate_public_ip_address, vpc_security_group_ids, ipv6_address… #228

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RealFatCat
Copy link

@RealFatCat RealFatCat commented Aug 11, 2022

…es, ipv6_address_count to aws_instance ignored fields for proper work with attached network interface.

Signed-off-by: Oleg Senin [email protected]

Description of your changes

Fix conflicts, when instance creates with network interface reference.
Example:

apiVersion: ec2.aws.jet.crossplane.io/v1alpha2
kind: Instance
metadata:
  name: instance-a
spec:
  forProvider:
    region: us-east-2
    ami: ami-0b332808c98813fef
    instanceType: c5.xlarge
    keyName: key
    networkInterface:
    - deviceIndex: 0
      networkInterfaceIdRef:
        name: ni-a
  deletionPolicy: Delete
  providerConfigRef:
    name: default

I am not quite sure, that this is good idea to just ignore this fields, but it seems like there is no other solution right now.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manual tests on aws.

…es, ipv6_address_count to aws_instance ignored fields for proper work with attached network interface.

Signed-off-by: Oleg Senin <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant