Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump master to 1.0 and mark as 'publish = false' #576

Closed
wants to merge 1 commit into from
Closed

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Oct 9, 2020

The current master branch contains breaking changes, but in the past, we've accidentally published a crate from master several times (#537 (comment)), and I had to yank each time.

This patch prevents releases from being accidentally created from the master branch by marking all crates as 'publish = false'.

Also, this bumps the master branch's version number to 1.0 (that should be the next major version we release). (The actual 1.0 release is blocked on #503.)

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jeehoonkang
Copy link
Contributor

I'm a little bit hesitant to bump to 1.0 now. One of the reasons is we merged quite a few large PRs recently. I propose to increase the minor version now, and if it works well for a certain period of time, bump the version to 1.0.

@taiki-e
Copy link
Member Author

taiki-e commented Oct 11, 2020

I propose to increase the minor version now, and if it works well for a certain period of time, bump the version to 1.0.

This seems to make sense, given that we can't really release 1.0 right away in any case. I'll file a PR for that.

@taiki-e taiki-e closed this Oct 11, 2020
@taiki-e taiki-e deleted the version branch October 11, 2020 08:11
bors bot added a commit that referenced this pull request Oct 12, 2020
581: Prepare for the next release r=jeehoonkang a=taiki-e

- crossbeam-channel 0.4.4 -> 0.5.0
- crossbeam-deque 0.7.3 -> 0.8.0
- crossbeam-epoch 0.8.2 -> 0.9.0
- crossbeam-queue 0.2.3 -> 0.3.0
- crossbeam-utils 0.7.2 -> 0.8.0
- crossbeam 0.7.3 -> 0.8.0

Replaces #576



Co-authored-by: Taiki Endo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants