APP-10298 : PanModalNavigationController 추가 #10
+293
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raymond-Sik
commented
Sep 24, 2024
There was a problem hiding this comment.
PanModalNavigationController를 PanModal 안으로 옮기게된 이유입니다.
- extension으로 구현한 PanModalPresentable 디폴트 값이 PanModal 라이브러리 내부와 ZigZag내부에 둘다 정의되어있음
- ZigZag에서 사용할 경우에는 ZigZag내부에 정의된 디폴트 값으로 덮어씌워지므로 상관 없음
- 피처모듈에서 사용할 경우 두 디폴트값중 어느 값을 사용해야할지 알 수 없다는 오류가 발생
- PanModal을 사용한 네비게이션 뷰컨이므로 PanModal 내부에 있는것이 더 맞다는 생각이 듦
There was a problem hiding this comment.
PanModal에서 사용하는 디자인 시스템 컬러값들이 있어서 별도로 정의해주었습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약
변경사항