Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: site decommissioning #43

Merged
merged 9 commits into from
Aug 22, 2024
Merged

feat: site decommissioning #43

merged 9 commits into from
Aug 22, 2024

Conversation

kpetremann
Copy link
Contributor

@kpetremann kpetremann commented Aug 21, 2024 •
edited
Loading

  • decommissioning of a site with one click in NetBox UI
  • decomm from the API for site and device
  • CMDB cleaning function has been factorized
  • use DELETE instead of POST to delete or decomm
  • rationalize endpoint names

Note: as the decommission can last few minutes, the results are show progressively:

  • on the UI: using HTMX to do delete queries progressively
  • on the API: using HTTP streaming

@kpetremann kpetremann force-pushed the site_decomm branch 2 times, most recently from f9ec7ff to 0fbae98 Compare August 21, 2024 14:15
@kpetremann kpetremann changed the title Site decommissioning feat: site decommissioning Aug 21, 2024
@kpetremann kpetremann requested review from a team August 21, 2024 14:25
fdomain
fdomain reviewed Aug 22, 2024
View reviewed changes
netbox_cmdb/netbox_cmdb/views.py Outdated Show resolved Hide resolved
netbox_cmdb/netbox_cmdb/views.py Outdated Show resolved Hide resolved
fdomain
fdomain approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@fdomain fdomain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, great job!

@kpetremann
Copy link
Contributor Author

thanks :)

@kpetremann kpetremann merged commit 79bdd05 into criteo:main Aug 22, 2024
2 checks passed
@kpetremann kpetremann deleted the site_decomm branch August 22, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdomain fdomain fdomain approved these changes

@mathieulaunay mathieulaunay mathieulaunay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpetremann @fdomain @mathieulaunay