Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements on BGP UI views #38

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Improvements on BGP UI views #38

merged 4 commits into from
Aug 5, 2024

Conversation

fdomain
Copy link
Contributor

@fdomain fdomain commented Aug 5, 2024

Description:

  • rework the BGP session edit page, to dynamically load BGP peers on typing
  • added route policy views (list/single object view), edit view doesn't allow yet to modify terms
  • added/fixed filters for the BGP table view

@fdomain
feat: rework BGP session edit page
0d046ad 
* peers are now loading dynamically with client-side scripting (before
  the page was taking ages to load due to the number of object)a
* added all the views and form to edit a DeviceBGPSession (but not
  directly accessible from the menu, since I plan to make it editable
  only via the BGP session view)
@fdomain
feat: add route policy views
eda0827
@fdomain
feat(ui): add refcount to bgp peer group table
fe1ba15
@fdomain fdomain requested a review from kpetremann August 5, 2024 08:14
@fdomain fdomain merged commit 665cca6 into criteo:main Aug 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpetremann kpetremann kpetremann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fdomain @kpetremann